Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get the number of close dht nodes with announce/store support #2357

Merged
merged 1 commit into from
Nov 13, 2023
Merged

feat: get the number of close dht nodes with announce/store support #2357

merged 1 commit into from
Nov 13, 2023

Conversation

Green-Sky
Copy link
Member

@Green-Sky Green-Sky commented Oct 26, 2022 •
edited
Loading

number of total and how many >= 0.2.18 peers you are connected with.

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Nov 10, 2023
iphydf
iphydf requested changes Nov 12, 2023
View reviewed changes
toxcore/tox_private.h Show resolved Hide resolved
toxcore/tox_private.h Outdated Show resolved Hide resolved
@pull-request-attention pull-request-attention bot assigned Green-Sky and iphydf and unassigned Green-Sky and iphydf Nov 12, 2023
@Green-Sky Green-Sky changed the title diagnostic: get the ratio of close dht nodes with announce/store support feat: get the ratio of close dht nodes with announce/store support Nov 12, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e337837) 74.51% compared to head (32041a1) 74.41%.
Report is 1 commits behind head on master.

❗ Current head 32041a1 differs from pull request most recent head 8099d82. Consider uploading reports for the commit 8099d82 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2357      +/-   ##
==========================================
- Coverage   74.51%   74.41%   -0.10%     
==========================================
  Files          87       87              
  Lines       26211    26235      +24     
==========================================
- Hits        19530    19523       -7     
- Misses       6681     6712      +31
Files Coverage Δ
toxcore/DHT.c 84.77% <100.00%> (-0.07%) ⬇️
toxcore/tox_private.c 55.69% <100.00%> (+6.42%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Green-Sky Green-Sky changed the title feat: get the ratio of close dht nodes with announce/store support feat: get the number of close dht nodes with announce/store support Nov 12, 2023
@Green-Sky Green-Sky force-pushed the caps_ratio branch 4 times, most recently from 0dea30f to 9ff7754 Compare November 12, 2023 20:55
@Green-Sky Green-Sky marked this pull request as ready for review November 12, 2023 21:02
@Green-Sky Green-Sky force-pushed the caps_ratio branch 3 times, most recently from 4fe8124 to 38178e6 Compare November 12, 2023 21:49
Green-Sky
Green-Sky commented Nov 12, 2023
View reviewed changes
Copy link
Member Author

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @iphydf)

a discussion (no related file):

Previously, iphydf wrote…

Raw numbers is better, I think. It avoids floats and gives additional information.

Done.

a discussion (no related file):

Previously, iphydf wrote…

(Reviewable was unable to map this GitHub inline comment thread to the right spot — sorry!)

Can we return a uint between 0 and 100? We don't currently have floats in the tox (or toxav) API. I'd prefer not to add them.

Done.

iphydf
iphydf requested changes Nov 12, 2023
View reviewed changes
toxcore/tox_private.c Outdated Show resolved Hide resolved
@Green-Sky Green-Sky requested a review from iphydf November 13, 2023 00:14
iphydf
iphydf requested changes Nov 13, 2023
View reviewed changes
toxcore/DHT.c Outdated Show resolved Hide resolved
iphydf
iphydf approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the int type fix.

@pull-request-attention pull-request-attention bot assigned iphydf and unassigned Green-Sky Nov 13, 2023
@Green-Sky Green-Sky merged commit 8099d82 into TokTok:master Nov 13, 2023
35 checks passed
@Green-Sky Green-Sky deleted the caps_ratio branch November 13, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iphydf iphydf iphydf approved these changes

Assignees

@iphydf iphydf

Labels
None yet
Projects
None yet
Milestone
v0.2.19
Development

Successfully merging this pull request may close these issues.
2 participants
@Green-Sky @iphydf