Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use Bin_Pack for packing Node_format. #2220

Closed
wants to merge 1 commit into from
Closed

refactor: Use Bin_Pack for packing Node_format. #2220

wants to merge 1 commit into from

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Mar 30, 2022 •
edited
Loading

This change is Reviewable

@iphydf iphydf added this to the v0.2.18 milestone Mar 30, 2022
@auto-add-label auto-add-label bot added the refactor Refactoring production code, eg. renaming a variable, not affecting semantics label Mar 30, 2022
@restyled-io restyled-io bot mentioned this pull request Mar 30, 2022
Closed
@codecov
Copy link

codecov bot commented Mar 30, 2022 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (d0304d8) 74.47% compared to head (8a19d0b) 74.49%.
Report is 1 commits behind head on master.

❗ Current head 8a19d0b differs from pull request most recent head 4a3e42b. Consider uploading reports for the commit 4a3e42b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2220      +/-   ##
==========================================
+ Coverage   74.47%   74.49%   +0.02%     
==========================================
  Files          87       87              
  Lines       26189    26203      +14     
==========================================
+ Hits        19505    19521      +16     
+ Misses       6684     6682       -2
Files Coverage Δ
toxcore/tox_events.c 78.70% <100.00%> (ø)
toxcore/Messenger.c 82.63% <75.00%> (-0.05%) ⬇️
toxcore/bin_pack.c 88.37% <94.73%> (+1.04%) ⬆️
toxcore/state.c 82.75% <0.00%> (ø)
toxcore/DHT.c 84.92% <93.33%> (+0.15%) ⬆️
toxcore/group.c 84.22% <0.00%> (-0.21%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the pack-nodes branch 6 times, most recently from 23ed60d to ba6d520 Compare April 3, 2022 15:44
@restyled-io restyled-io bot mentioned this pull request Apr 3, 2022
Closed
@iphydf iphydf force-pushed the pack-nodes branch 11 times, most recently from f41e3f0 to 1b25981 Compare April 7, 2022 20:32
@iphydf iphydf modified the milestones: v0.2.18, v0.2.19 Apr 7, 2022
@iphydf iphydf force-pushed the pack-nodes branch 2 times, most recently from 3b8bfdb to c13d6fc Compare April 14, 2022 21:47
@iphydf iphydf modified the milestones: v0.2.19, v0.2.20 Apr 18, 2022
@iphydf iphydf force-pushed the pack-nodes branch 2 times, most recently from ad85f09 to 0481dd1 Compare April 23, 2022 07:25
@iphydf iphydf requested a review from a team as a code owner April 23, 2022 07:25
sudden6
sudden6 approved these changes Apr 23, 2022
View reviewed changes
Copy link

@sudden6 sudden6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@iphydf iphydf modified the milestones: v0.2.20, v0.2.19 Apr 25, 2022
@iphydf iphydf closed this Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudden6 sudden6 sudden6 approved these changes

Assignees

@iphydf iphydf

Labels
refactor Refactoring production code, eg. renaming a variable, not affecting semantics
Projects
None yet
Milestone
v0.2.19
Development

Successfully merging this pull request may close these issues.
2 participants
@iphydf @sudden6