refactor: Store time in Mono_Time in milliseconds. #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-add-label
bot
added
the
refactor
iphydf
force-pushed
the
mono-time-ms
branch
6 times, most recently
from
5d1c5d2 to
61715e5
Compare
iphydf
force-pushed
the
mono-time-ms
branch
2 times, most recently
from
09f510a to
7ae51ec
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2203 +/- ##
==========================================
+ Coverage 74.49% 74.58% +0.08%
==========================================
Files 87 87
Lines 26243 26244 +1
==========================================
+ Hits 19551 19573 +22
+ Misses 6692 6671 -21 ☔ View full report in Codecov by Sentry. |
Green-Sky
reviewed
Nov 10, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 1 approvals obtained
Green-Sky
approved these changes
Nov 10, 2023
Conversion to seconds happens in `mono_time_get`, and a new function `mono_time_get_ms` allows code to retrieve monotonic time in milliseconds.
JFreegman
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! 2 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion to seconds happens in
mono_time_get, and a new functionmono_time_get_msallows code to retrieve monotonic time inmilliseconds.
This change is