Make group callbacks stateless

[JFreegman]

---

This change is NOT reviewable. Use Github reviews instead.

[sudden6]

Review status: 0 of 10 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

toxcore/Messenger.c, line 821 at r1 (raw file):

    m->friendlist[friendnumber].statusmessage_length = length;
    return 0;group_invite)(m, i

huh, what's that?

---

Comments from Reviewable

[JFreegman]

toxcore/Messenger.c, line 821 at r1 (raw file):

Previously, sudden6 wrote…

huh, what's that?

Think I must've accidentally ctrl+v'd before I pushed.

---

Comments from Reviewable

[GrayHatter]

Reviewed 7 of 10 files at r1, 2 of 2 files at r2.
Review status: 9 of 10 files reviewed at latest revision, 3 unresolved discussions.

---

toxcore/group.c, line 455 at r2 (raw file):

    add_to_closest(g_c, groupnumber, real_pk, temp_pk);

    if (do_gc_callback && g_c->group_namelistchange) {

Do we want a comment here explaining that this isn't the desired behavior?

---

toxcore/group.c, line 459 at r2 (raw file):

    }

    if (g->peer_on_join) {

does this need to check do_gc_callback?

---

toxcore/Messenger.h, line 257 at r2 (raw file):

    void *group_chat_object; /* Set by new_groupchats()*/
    void (*group_invite)(struct Messenger *m, uint32_t, const uint8_t *, uint16_t);
    void (*group_message)(struct Messenger *m, uint32_t, const uint8_t *, uint16_t);

Where was this moved? Or why was it here?

---

Comments from Reviewable

[JFreegman]

Review status: 9 of 10 files reviewed at latest revision, 3 unresolved discussions.

---

toxcore/group.c, line 455 at r2 (raw file):

Previously, GrayHatter (Gregory Mullen) wrote…

Do we want a comment here explaining that this isn't the desired behavior?

I'm not sure what you mean. This behaviour is desired - we want to control when the callback is triggered.

---

toxcore/group.c, line 459 at r2 (raw file):

Previously, GrayHatter (Gregory Mullen) wrote…

does this need to check do_gc_callback?

That callback doesn't take a userdata object so it should be safe. It and the other two callbacks inside the Group_C struct are set by ToxAV, rather than by the public API. I'm not sure what disabling them would do, but it's something we might want to look into outside of this PR.

---

toxcore/Messenger.h, line 257 at r2 (raw file):

Previously, GrayHatter (Gregory Mullen) wrote…

Where was this moved? Or why was it here?

That was always there. It's needed in Messenger because there's no group yet when you receive an invite packet.

---

Comments from Reviewable

[JFreegman]

toxcore/Messenger.h, line 257 at r2 (raw file):

Previously, JFreegman wrote…

That was always there. It's needed in Messenger because there's no group yet when you receive an invite packet.

Oh you meant group_message, for some reason reviewable hid that line from your quote. I have no idea what it was for, but it wasn't being used and seemed out of place so I removed it.

---

Comments from Reviewable

[GrayHatter]

---

Reviewed 1 of 10 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

toxcore/group.c, line 455 at r2 (raw file):

Previously, JFreegman wrote…

I'm not sure what you mean. This behaviour is desired - we want to control when the callback is triggered.

no I mean the desired behavior is not having to make this check because tox_iterate() is supposed to be the only function sending callbacks.

---

toxcore/Messenger.h, line 257 at r2 (raw file):

Previously, JFreegman wrote…

Oh you meant group_message, for some reason reviewable hid that line from your quote. I have no idea what it was for, but it wasn't being used and seemed out of place so I removed it.

LGTM

That's what I figured, just wanted to make sure.

---

Comments from Reviewable

[JFreegman]

Review status: 9 of 10 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

toxcore/group.c, line 455 at r2 (raw file):

Previously, GrayHatter (Gregory Mullen) wrote…

no I mean the desired behavior is not having to make this check because tox_iterate() is supposed to be the only function sending callbacks.

Done.

---

Comments from Reviewable

[GrayHatter]

---

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[nurupo]

Reviewed 8 of 10 files at r1, 1 of 2 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[nurupo]

---

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable