Ensure save data unchanged after save and load #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugz
force-pushed
the
saveInvariance
branch
from
b714ef0 to
0c514ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #1215 +/- ##
========================================
+ Coverage 82.9% 83% +0.1%
========================================
Files 82 82
Lines 14647 14692 +45
========================================
+ Hits 12146 12200 +54
+ Misses 2501 2492 -9
Continue to review full report at Codecov.
|
zugz
force-pushed
the
saveInvariance
branch
5 times, most recently
from
d7dd0cf to
ba976bb
Compare
iphydf
requested changes
Oct 7, 2018
auto_tests/save_load_test.c
Outdated
| tox_get_savedata(*tox, buffer + extra); | ||
| tox_kill(*tox); | ||
|
|
||
| for (size_t i = 0; i < extra; i++) { |
toxcore/TCP_client.c
Outdated
| @@ -419,17 +419,6 @@ static bool client_add_priority(TCP_Client_Connection *con, const uint8_t *packe | |||
| return 1; | |||
| } | |||
|
|
|||
| static void wipe_priority_list(TCP_Client_Connection *con) | |||
|
* Sunday, 2018-10-07 at 15:56 -0700 - iphydf <[email protected]>:
There is a lot of newlines here. Was that intentional?
It's what astyle demands, presumably due to a bug in astyle.
|
iphydf
approved these changes
Oct 10, 2018
toxcore/DHT.c
Outdated
| @@ -2803,6 +2803,11 @@ uint32_t dht_size(const DHT *dht) | |||
| uint32_t numv4 = 0; | |||
| uint32_t numv6 = 0; | |||
|
|
|||
| for (uint32_t i = 0; i < dht->loaded_num_nodes; ++i) { | |||
| numv4 += (net_family_is_ipv4(dht->loaded_nodes_list[i].ip_port.ip.family)); | |||
There was a problem hiding this comment.
Remove extra () around function call.
iphydf
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is