-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some improvements to tox-bootstrapd's Dockerfile #1211
Conversation
|
b20eb7d
to
37bd08c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: 0 of 1 approvals obtained
37bd08c
to
cd2bab2
Compare
Rebased and CI passes. Removing the CI enabling commit. |
cd2bab2
to
8bef9fc
Compare
LGTM - feel free to rebase and merge (I can't do it for you). |
8bef9fc
to
58f2b92
Compare
Codecov Report
@@ Coverage Diff @@
## master #1211 +/- ##
========================================
- Coverage 83% 82.9% -0.1%
========================================
Files 82 82
Lines 14692 14645 -47
========================================
- Hits 12195 12143 -52
- Misses 2497 2502 +5
Continue to review full report at Codecov.
|
Done. Thanks for removing the WIP. Have you noticed that while Dockerfile checks out the greatest version number tag, the CI script seds the Dockerfile to run tests against the current changes instead? You should have seen that if you checked the patch, though I decided to point it out. I was looking for some Dockerfile condition thingy where it would do different thing if CI=true env variable is set, but alas there is no such functionality, at least not in the building stage of the container. |
Yes, I noticed that when I was adding a test for the alpine dockerfile (which I then deleted - and I dropped the PR for testing the dockerfile). LGTM => rebase. |
58f2b92
to
b6dde3c
Compare
Rebased. |
Users probably shouldn't run toxcore master, running the highest version tag sounds better.
Switched it to use cmake to build toxcore instead of sing autotools while I was at it, since we are supposedly phasing out autotools at some point (maybe?).
This change is