Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using massive macros in toxav_basic_test. #1120

Merged
merged 1 commit into from
Aug 25, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Aug 25, 2018

Turned a huge macro into a function. Macros are a pain to debug.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Aug 25, 2018
@iphydf iphydf force-pushed the regular-call-flow branch from c862666 to fb07b6f Compare August 25, 2018 12:28
@codecov
Copy link

codecov bot commented Aug 25, 2018

Codecov Report

Merging #1120 into master will increase coverage by <.1%.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1120     +/-   ##
========================================
+ Coverage    82.5%   82.5%   +<.1%     
========================================
  Files          80      80             
  Lines       14318   14339     +21     
========================================
+ Hits        11819   11838     +19     
- Misses       2499    2501      +2
Impacted Files Coverage Δ
auto_tests/toxav_basic_test.c 83.5% <75%> (-1.4%) ⬇️
toxcore/group.c 71.7% <0%> (-1.5%) ⬇️
toxcore/Messenger.c 86.1% <0%> (-0.1%) ⬇️
toxcore/onion_client.c 95% <0%> (+0.6%) ⬆️
toxcore/LAN_discovery.c 84.9% <0%> (+0.9%) ⬆️
toxav/msi.c 65% <0%> (+1.1%) ⬆️
toxav/toxav.c 68.8% <0%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efcda6c...853a2a1. Read the comment docs.

@iphydf iphydf force-pushed the regular-call-flow branch from fb07b6f to 6ad6db4 Compare August 25, 2018 12:48
Copy link

@sudden6 sudden6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 approvals obtained (waiting on @iphydf)


auto_tests/toxav_basic_test.c, line 107 at r1 (raw file):

    int a_br, int v_br)
{
    memset(AliceCC, 0, sizeof(CallControl));

memset on a struct is not very nice, at least add a todo/fixme comment

@iphydf iphydf force-pushed the regular-call-flow branch from 6ad6db4 to 97ee97a Compare August 25, 2018 13:10
Copy link
Member Author

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @sudden6)


auto_tests/toxav_basic_test.c, line 107 at r1 (raw file):

Previously, sudden6 wrote…

memset on a struct is not very nice, at least add a todo/fixme comment

Done.

Turned a huge macro into a function. Macros are a pain to debug.
@iphydf iphydf force-pushed the regular-call-flow branch from 97ee97a to 853a2a1 Compare August 25, 2018 13:46
Copy link

@sudden6 sudden6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: 1 change requests, 0 of 1 approvals obtained

@iphydf iphydf merged commit 853a2a1 into TokTok:master Aug 25, 2018
@iphydf iphydf deleted the regular-call-flow branch August 25, 2018 13:56
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.7 Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants