Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment intentional switch fallthroughs #110

Merged
merged 1 commit into from
Sep 7, 2016

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented Sep 7, 2016

This change is Reviewable

@JFreegman JFreegman assigned GrayHatter, nurupo, iphydf and mannol and unassigned GrayHatter and mannol Sep 7, 2016
@GrayHatter
Copy link

Assigns me
then unassigns me (so I'll still get the notification spam)

Fuket, I'm reviewing it anyways.

IMO, the comments should be on the same line, not a new one.

:lgtm:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@GrayHatter
Copy link

This fails the auto-style checks.


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@JFreegman JFreegman force-pushed the toktok-switch branch 2 times, most recently from 18a0306 to 85a871d Compare September 7, 2016 20:58
@iphydf
Copy link
Member

iphydf commented Sep 7, 2016

:lgtm:


Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Sep 7, 2016

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.


toxcore/Messenger.c, line 841 [r2] (raw file):

                              void *))
{
    callback_friendrequest(&(m->fr), (void ( *)(void *, const uint8_t *, const uint8_t *, size_t, void *))function, m);

Please undo this whitespace change.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Sep 7, 2016

:lgtm:


Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@iphydf iphydf assigned GrayHatter and unassigned nurupo Sep 7, 2016
@iphydf
Copy link
Member

iphydf commented Sep 7, 2016

Reviewed 2 of 3 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Sep 7, 2016

:lgtm:


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@GrayHatter
Copy link

:lgtm_strong:


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@GrayHatter
Copy link

Reviewed 2 of 3 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


Comments from Reviewable

@iphydf iphydf merged commit 27a1626 into TokTok:master Sep 7, 2016
@JFreegman JFreegman deleted the toktok-switch branch September 13, 2016 04:27
@iphydf iphydf modified the milestone: v0.0.1 Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants