Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conference_by_uid and conference_get_uid functions. #1001

Merged
merged 1 commit into from
Jul 13, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jul 13, 2018

These are useful once we have persistent group chats, so clients can
store data associated with this permanent group identifier.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Jul 13, 2018
@iphydf iphydf force-pushed the pgc-conf-by-uid branch 4 times, most recently from a16c4da to 91100e5 Compare July 13, 2018 19:28
These are useful once we have persistent group chats, so clients can
store data associated with this permanent group identifier.
@iphydf iphydf force-pushed the pgc-conf-by-uid branch from 91100e5 to 90a63e8 Compare July 13, 2018 19:30
Copy link
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 3 of 5 files at r1, 3 of 3 files at r2, 5 of 5 files at r3.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@iphydf iphydf merged commit 90a63e8 into TokTok:master Jul 13, 2018
@iphydf iphydf deleted the pgc-conf-by-uid branch July 13, 2018 19:38
@iphydf iphydf modified the milestones: v0.2.x, v0.2.4 Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants