Fix 로컬스토리지 관리 로직 수정 #142
Merged
Fix 로컬스토리지 관리 로직 수정 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
상수 관리 - expireDays 5일 삭제: JwtToken에 대한 expire는 이미 payload에 포함되어 있음 - 두 매직넘버를 상수로 표현 - JWT_PART_LENGTH : JWT 토큰은 헤더 | 페이로드 | 시그니처 3부분 - MS_PER_SEC : 1초 = 1000밀리초 Jwt 오브젝트가 아닌 토큰(string)만 보관 - expire가 기능적으로 중복되어 있음 - 토큰(string)만 저장토록 수정 - saveToekn & getToken 함수 인자나 반환형태가 변하지 않아 기존 코드와 호환 가능 saveToken() - 로컬스토리지에 저장하는 형태를 string으로 변경 clearToken() - 로컬스토리지 clear아닌 removeItem으로 수정 getToken() - 기존과 동일하게 동작 - 유효하지 않은 토큰은 로컬스토리지에서 삭제 & null 리턴 - 유효한 토큰만 string 리턴
seo-wo
previously approved these changes
Dec 20, 2023
… 141-TokenStorage_refactor
seo-wo
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
상수 관리
Jwt 오브젝트가 아닌 토큰(string)만 보관
saveToken()
clearToken()
getToken()
close #141