Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spotless #35

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Fix spotless #35

merged 1 commit into from
Sep 8, 2021

Conversation

illuminator3
Copy link
Contributor

This fixes diffplug/spotless#834 by removing the unused imports setting.

@illuminator3 illuminator3 changed the base branch from master to develop September 8, 2021 13:00
@illuminator3 illuminator3 self-assigned this Sep 8, 2021
@illuminator3 illuminator3 added the bug Something isn't working label Sep 8, 2021
@illuminator3 illuminator3 merged commit 0df17f3 into Together-Java:develop Sep 8, 2021
@illuminator3 illuminator3 deleted the fix-spotless branch September 8, 2021 13:10
Tais993 added a commit that referenced this pull request Sep 8, 2021
@Tais993 @I-Al-Istannen
@marko-radosavljevic @illuminator3
Pull'd develop branch
c487ea0 
* Bump JDA version to 324 (#31)

Updates JDA (they forgot something with slash-commands, has been added now)

* Add spotless integration

This hopefully makes formatting more consistent. The Eclipse XML style
was chosen as it is understood by Eclipse, VSC (JDT), Spotless and
mostly by IntelliJ.

* Make gradelew executable

* Add "Remove unused imports" setting to spotless

Co-authored-by: Marko Radosavljević <[email protected]>

* Remove unused imports to fix diffplug/spotless#834 (#35)

Co-authored-by: I-Al-Istannen <[email protected]>
Co-authored-by: Marko Radosavljević <[email protected]>
Co-authored-by: Jonas <[email protected]>
@Tais993 Tais993 mentioned this pull request Sep 8, 2021
Closed
@Zabuzard Zabuzard added this to the Initial Setup milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marko-radosavljevic marko-radosavljevic marko-radosavljevic approved these changes

@I-Al-Istannen I-Al-Istannen I-Al-Istannen approved these changes

@Zabuzard Zabuzard Awaiting requested review from Zabuzard

Assignees

@illuminator3 illuminator3

Labels
bug Something isn't working
Projects
None yet
Milestone
Initial Setup
Development

Successfully merging this pull request may close these issues.

google-java-format (and removeUnusedImports) broken on JDK 16+ (has workaround)
4 participants
@illuminator3 @I-Al-Istannen @marko-radosavljevic @Zabuzard