-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(BigQuery): Add support for column descriptions in nested fields #3887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themisvaltinos
commented
Feb 24, 2025
97afa1d
to
e673305
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more comments, but LGTM otherwise.
94a8d3b
to
36467db
Compare
…sts; Run bigquery test
36467db
to
ad06c9f
Compare
georgesittas
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for column descriptions in nested types in BigQuery, closes #3854
The syntax follows BigQuery's conventions for nested and repeated columns, using dots to indicate the appropriate level of nesting:
The column definitions are built using the helper method
_build_column_def
, which is applied recursively in the BigQuery adapter to handle the RECORD and REPEATED RECORD columns. For views which are registered in_create_column_comments
we traverse the fields and apply comments at each appropriate level.