Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Warn when SQLMesh automatically adjusts a restatement range to cover the whole model #3850

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

erindru
Copy link
Collaborator

@erindru erindru commented Feb 16, 2025

Prior to this change, if you tried to restate eg 1 day of a model that is full_history_restatement_only, for example an INCREMENTAL_BY_UNIQUE_KEY model:

$ sqlmesh plan --restate-model sqlmesh_example.unique_key_model --start 2020-01-01 --end 2020-01-02

No changes to plan: project files match the `prod` environment

Models needing backfill:
└── sqlmesh_example.unique_key_model: [2020-01-01 - 2020-01-10]

SQLMesh would automatically adjust the backfill intervals to cover the entire model without making it obvious to the user.

Even if the user notices that the end date in this example was changed to 2020-01-10 they may be confused as to why SQLMesh ignored their specified end date of 2020-01-02.

This PR adds a warning like so:

$ sqlmesh plan --restate-model sqlmesh_example.unique_key_model --start 2020-01-01 --end 2020-01-02

[WARNING] Model 'sqlmesh_example.unique_key_model' is 'INCREMENTAL_BY_UNIQUE_KEY' which does not support partial restatement.
Expanding the requested restatement intervals from [2020-01-01 - 2020-01-02] to [2020-01-01 - 2020-01-10] in order to fully restate the model.

No changes to plan: project files match the `prod` environment

Models needing backfill:
└── sqlmesh_example.unique_key_model: [2020-01-01 - 2020-01-10]

@erindru
Copy link
Collaborator Author

erindru commented Feb 17, 2025

The test failures are related to #3851

@erindru erindru force-pushed the erin/warn-on-full-restatement branch from 95e922e to b99cd59 Compare February 17, 2025 02:10
@erindru erindru merged commit d18453b into main Feb 17, 2025
21 checks passed
@erindru erindru deleted the erin/warn-on-full-restatement branch February 17, 2025 19:26
justinjoseph89 added a commit to trygforsikring/sqlmesh that referenced this pull request Feb 20, 2025
* Chore: replace mysql-connector-python with pymysql (TobikoData#3788)

* feat: don't force db connect if using serverless (TobikoData#3786)

* Feat: Add 'auditing' and 'promoting' runtime stages (TobikoData#3791)

* fix: databricks set default catalog for both connections (TobikoData#3793)

* Docs: Prod Env Observability updates (TobikoData#3790)

Co-authored-by: Trey Spiller <[email protected]>
Co-authored-by: Trey Spiller <[email protected]>

* Docs: update jinja gateway variable syntax (TobikoData#3795)

* Fix: Only promote all snapshots if the target environment expired (TobikoData#3797)

* Chore: remove [missing dates] from CLI model backfills title (TobikoData#3796)

* Fix: Make sure that physical tables exist for promoted snapshots (TobikoData#3798)

* fix: db properly support `with_log_level` (TobikoData#3799)

* fix: run integration tests in session (TobikoData#3801)

* Fix: specify init duckdb database so quickstart works (TobikoData#3800)

* Docs: clarify in faq that run ignores local definitions  (TobikoData#3794)

* feat: add airflow operator and hook for ClickHouse (TobikoData#3699)

* Feat: Allow macros in python model properties (TobikoData#3740)

* Docs: update CLI quickstart's CLI output (TobikoData#3802)

* Fix: Ensure diff sample displays when table names have been uppercased (TobikoData#3806)

* Fix: update github links for pdoc api docs (TobikoData#3807)

* Feat: Run audits as non-blocking on dev previews (TobikoData#3809)

* Chore!: bump sqlglot to v26.6.0 (TobikoData#3810)

* Feat!: Adjust physical_properties evaluation and add macro to resolve physical table names (TobikoData#3772)

* Chore: Use 'dev' suffix instead of 'temp' for non-deployable physical tables (TobikoData#3803)

* Fix!: Propagate the grain attribute when converting dbt models (TobikoData#3804)

* Docs(dagster): Fix installation instructions (TobikoData#3812)

* fix: add kwargs to build_table_properties_exp (TobikoData#3817)

* Feat: include alter statements in destructive change error message (TobikoData#3805)

* Dagster demo and tutorial video (TobikoData#3822)

* fix: databricks with_log_level (TobikoData#3823)

* Feat: improve audit error message formatting (TobikoData#3818)

* Fix(postgres): Quote role names if required when running SET ROLE on cursor init (TobikoData#3825)

* Fix: handle quoted projects properly in bigquery adapter (TobikoData#3820)

* Chore: Fix flaky test (TobikoData#3828)

* docs: adding self hosted executor docs (TobikoData#3816)

* Revert "Fix(postgres): Quote role names if required when running SET ROLE on cursor init" (TobikoData#3834)

* Fix: Don't fail because of an unrestorable change if the target model is forward-only (TobikoData#3835)

* Chore: improve metadata update console printing (TobikoData#3824)

* fix: respect disable_restatement remove intervals across env (TobikoData#3838)

* fix: respect disable restate dev unpaused snapshots (TobikoData#3840)

* Feat: add [WARNING] to console warning messages (TobikoData#3826)

* Feat: Extend support of project wide model properties (TobikoData#3832)

* Fix: Streamline execution of pre- / post- statements when creating a physical table (TobikoData#3837)

* fix: signals that return an empty list are considered ready (TobikoData#3841)

* Chore: Add the ingress section to the self-hosted executor docs

* Fix: Snapshots promoted in prod shouldn't be restated in dev (TobikoData#3843)

* Fix: Inference of python model names from the file system (TobikoData#3844)

* feat: add support for datetime/date in macros (TobikoData#3846)

* fix: only expand restatement range if incremental (TobikoData#3847)

* feat: improve gcp postgres connection config options (TobikoData#3842)

* Fix: Pin PyGithub to 2.5.0 so tests can run (TobikoData#3851)

* Fix: Warn when SQLMesh automatically adjusts a restatement range to cover the whole model (TobikoData#3850)

* fix!: normalize catalog override name (TobikoData#3849)

* Feat: allow different warning messages for logger and console (TobikoData#3836)

* Chore: fix audit doc typos (TobikoData#3856)

* Add airflow tutorial video (TobikoData#3860)

* Feat!: add model blueprinting (TobikoData#3848)

* Fix: Make sure that pending restatement intervals are always recorded last during compaction (TobikoData#3862)

* Chore: Break up the plan_builder method in Context (TobikoData#3867)

* fix: give better error message when object not serializable (TobikoData#3861)

* Feat: make date_spine macro less strict to allow dynamic behavior (TobikoData#3865)

* Add Tcloud SSO docs (TobikoData#3827)

* Fix: Unexpected backfill of a parent of a changed forward-only child when the child runs before the parent (TobikoData#3871)

* Feat: Allow CustomKind subclasses for custom materializations (TobikoData#3863)

* Chore: consolidate `make install-*` (TobikoData#3874)

---------

Co-authored-by: Trey Spiller <[email protected]>
Co-authored-by: Ryan Eakman <[email protected]>
Co-authored-by: Iaroslav Zeigerman <[email protected]>
Co-authored-by: Marisa Smith <[email protected]>
Co-authored-by: Trey Spiller <[email protected]>
Co-authored-by: Anton Parfenyuk <[email protected]>
Co-authored-by: Themis Valtinos <[email protected]>
Co-authored-by: Gerasimos Kounadis <[email protected]>
Co-authored-by: Erin Drummond <[email protected]>
Co-authored-by: Jo <[email protected]>
Co-authored-by: Sung Won Chung <[email protected]>
Co-authored-by: Ben <[email protected]>
Co-authored-by: Philippe Laflamme <[email protected]>
Co-authored-by: Toby Mao <[email protected]>
Co-authored-by: Afzal Jasani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants