Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Change gateway naming and render False values on project init #3774

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Fix: Change gateway naming and render False values on project init #3774

merged 1 commit into from
Feb 4, 2025

Conversation

VaggelisD
Copy link
Contributor

This PR addresses the following issues:

  • The False default values were not rendered due to the logical disjunction
  • The default gateway is renamed to <dialect> instead of dev to avoid confusion with prod/dev
  • The tests freeze time to avoid sync issues with yesterday_ds() if the day is changed

@VaggelisD VaggelisD merged commit 0b4ee9e into main Feb 4, 2025
21 checks passed
@VaggelisD VaggelisD deleted the vaggelisd/init_project_ux branch February 4, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas approved these changes

@izeigerman izeigerman Awaiting requested review from izeigerman

@tobymao tobymao Awaiting requested review from tobymao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VaggelisD @georgesittas