Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: put connection config link in a separate line #3760

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

georgesittas
Copy link
Contributor

@georgesittas georgesittas commented Jan 31, 2025

Small change to get configs to look like this instead of having a single big comment for the config connection link. Added another link to the base connection configs because they're missing from individual connection pages.

gateways:
  dev:
    connection:
      # For more information on configuring the connection to your execution engine, visit:
      # https://sqlmesh.readthedocs.io/en/stable/reference/configuration/#connections
      # https://sqlmesh.readthedocs.io/en/stable/integrations/engines/duckdb/#connection-options
      type: duckdb
      # concurrent_tasks: 1
      # register_comments: True
      # pre_ping: 
      # pretty_sql: 
      # database: 
      # catalogs: 
      # extensions: 
      # connector_config: 
      # token: 


default_gateway: dev

model_defaults:
  dialect: duckdb
  start: 2025-01-30

@georgesittas georgesittas force-pushed the jo/fix_link_formatting branch from 62617d1 to 61318cb Compare January 31, 2025 09:54
Copy link
Contributor

@VaggelisD VaggelisD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better UX, thanks!

@georgesittas georgesittas merged commit a01a455 into main Jan 31, 2025
21 checks passed
@georgesittas georgesittas deleted the jo/fix_link_formatting branch January 31, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants