-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: improve CLI node evaluation error display #3706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3355e71
to
f461290
Compare
izeigerman
reviewed
Jan 24, 2025
izeigerman
reviewed
Jan 24, 2025
izeigerman
reviewed
Jan 24, 2025
izeigerman
reviewed
Jan 24, 2025
izeigerman
reviewed
Jan 24, 2025
izeigerman
reviewed
Jan 24, 2025
izeigerman
reviewed
Jan 24, 2025
14ee633
to
e36468d
Compare
izeigerman
reviewed
Jan 27, 2025
izeigerman
reviewed
Jan 27, 2025
izeigerman
reviewed
Jan 27, 2025
izeigerman
reviewed
Jan 27, 2025
izeigerman
reviewed
Jan 27, 2025
izeigerman
reviewed
Jan 27, 2025
izeigerman
reviewed
Jan 27, 2025
izeigerman
reviewed
Jan 27, 2025
bb30698
to
26f6abb
Compare
izeigerman
reviewed
Jan 29, 2025
izeigerman
reviewed
Jan 29, 2025
izeigerman
reviewed
Jan 29, 2025
izeigerman
reviewed
Jan 29, 2025
izeigerman
reviewed
Jan 29, 2025
izeigerman
reviewed
Jan 29, 2025
izeigerman
reviewed
Jan 29, 2025
izeigerman
reviewed
Jan 29, 2025
izeigerman
reviewed
Jan 29, 2025
izeigerman
reviewed
Jan 29, 2025
izeigerman
reviewed
Jan 29, 2025
6ff9e76
to
71dcde4
Compare
izeigerman
reviewed
Jan 29, 2025
71dcde4
to
64da822
Compare
izeigerman
reviewed
Jan 30, 2025
izeigerman
reviewed
Jan 30, 2025
izeigerman
reviewed
Jan 30, 2025
izeigerman
reviewed
Jan 30, 2025
izeigerman
approved these changes
Jan 30, 2025
64da822
to
f0e3119
Compare
f0e3119
to
33d743c
Compare
treysp
added a commit
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI currently prints duplicate/unnecessary error information when a a node evaluation error occurs.
This PR removes the duplication, the unnecessary information, and improves error message formatting.
Background
We currently use multiple approaches to print errors to CLI:
console.log_error()
is a method we defined to print red text to CLIlogger.error()
is a standard method that prints to both CLI output and lograise
and/or use ofClick.ClickException()
Calls to these are spread out, can be duplicative, and do not format the displayed error.
Changes
This PR resolves this by separating these three actions:
log_failed_models()
andlog_skipped_models()
logger.info()
so it doesn't also print to CLIPythonModelEvalError
to differentiate from SQL eval errors