Feat: Support top level properties in model_defaults #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erindru
reviewed
Jan 23, 2025
themisvaltinos
force-pushed
the
themis/model_defaults
branch
from
dce784a to
1154b8e
Compare
| session_properties[k] = exp.Literal.string(k).eq(v) | ||
| if k not in properties: | ||
| properties[k] = exp.Literal.string(k).eq(v) | ||
| elif properties[k].expression.sql().lower() in {"none", "null"}: |
There was a problem hiding this comment.
Is matching null here safe? Can that be an actual property value?
There was a problem hiding this comment.
This is to match for python models properties where None will be null here
georgesittas
approved these changes
Jan 29, 2025
themisvaltinos
force-pushed
the
themis/model_defaults
branch
from
1154b8e to
96187e0
Compare
treysp
pushed a commit
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update extends the support for top-level properties to be enabled project wide, fixes: #3599
Don't know if it makes sense to include more, as the others seem quite model-specific, but I’m happy to add them if anyone feels they’re necessary.