Fix: Dont reuse the dev table version for non-materialized models #3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erindru
approved these changes
Jan 23, 2025
|
Something is wrong with GH reporting. The build is green on CircleCI: https://app.circleci.com/pipelines/github/TobikoData/sqlmesh/17727/workflows/c3364337-1510-4166-9e6f-b940df9290e8 |
|
I would rebase this branch on |
izeigerman
force-pushed
the
fix-reuse-temp-version-for-materialized-snapshots-only
branch
from
1279e64 to
24a20b4
Compare
izeigerman
deleted the
fix-reuse-temp-version-for-materialized-snapshots-only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that when reusing the dev physical table for view models, it sometimes result in stale views that point at deleted snapshot tables.