Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add risingwave engine adapter support for sqlmesh. #3436

Merged
merged 27 commits into from
Feb 26, 2025

Conversation

lin0303-siyuan
Copy link
Contributor

Risingwave engine adapter is functioning well with simple model tests like create view, post statements...

@tobymao
Copy link
Contributor

tobymao commented Dec 11, 2024

@lin0303-siyuan do you have plans to finish this?

@lin0303-siyuan
Copy link
Contributor Author

@tobymao Hi Toby, I have some issues last two weeks and plan to resume this week.

@lin0303-siyuan
Copy link
Contributor Author

Hi maintainers, I have pushed new commits and am willing to hear from your feedbacks about the risingwave engine adatper.

@erindru
Copy link
Collaborator

erindru commented Jan 21, 2025

Can you please also add a docs page for risingwave?

See the existing ones for examples. It basically just needs to tell people how to install it, what the connection options are and any risingwave limitations / quirks that you are aware of

@lin0303-siyuan
Copy link
Contributor Author

Can you please also add a docs page for risingwave?

See the existing ones for examples. It basically just needs to tell people how to install it, what the connection options are and any risingwave limitations / quirks that you are aware of

Sure, please see the new commit.

@tobymao
Copy link
Contributor

tobymao commented Feb 20, 2025

closing for now as there's been no progress. feel free to reopen when ready

@tobymao tobymao closed this Feb 20, 2025
@lin0303-siyuan
Copy link
Contributor Author

Hi maintainers, I am really sorry that I am out of work for the past month for personal issues. And now I want to continue to work on this pr, but I don't permission to reopen the pr, could you please reopen for me?
Really appreciate.

@erindru erindru reopened this Feb 26, 2025
@lin0303-siyuan
Copy link
Contributor Author

Could you please review and give further suggestions, appreciate.

@erindru erindru merged commit bb7cb1a into TobikoData:main Feb 26, 2025
19 checks passed
@erindru
Copy link
Collaborator

erindru commented Feb 26, 2025

Thanks for your contribution @lin0303-siyuan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants