Add tests for anyObjects

Creating a 'device' object
Tirasa · Oct 2, 2023 · 2f33c4b · 2f33c4b
1 parent 97c932e
commit 2f33c4b
Show file tree

Hide file tree

Showing 3 changed files with 82 additions and 0 deletions.
diff --git a/src/test/java/net/tirasa/connid/bundles/ldap/LdapConfigurationTests.java b/src/test/java/net/tirasa/connid/bundles/ldap/LdapConfigurationTests.java
@@ -113,6 +113,42 @@ public void accountUserNameAttributesItemNotNull() {
         assertThrows(ConfigurationException.class, () -> config.validate());
     }
 
+    @Test
+    public void anyObjectNameAttributesNotEmpty() {
+        config.setAnyObjectNameAttributes();
+        assertThrows(ConfigurationException.class, () -> config.validate());
+    }
+
+    @Test
+    public void anyObjectNameAttributesNotNull() {
+        config.setAnyObjectNameAttributes((String) null);
+        assertThrows(ConfigurationException.class, () -> config.validate());
+    }
+
+    @Test
+    public void anyObjectNameAttributesNotBlank() {
+        config.setAnyObjectNameAttributes(" ");
+        assertThrows(ConfigurationException.class, () -> config.validate());
+    }
+
+    @Test
+    public void anyObjectClassesNotEmpty() {
+        config.setAnyObjectClasses();
+        assertThrows(ConfigurationException.class, () -> config.validate());
+    }
+
+    @Test
+    public void anyObjectClassesNotNull() {
+        config.setAnyObjectClasses((String) null);
+        assertThrows(ConfigurationException.class, () -> config.validate());
+    }
+
+    @Test
+    public void anyObjectClassesNotBlank() {
+        config.setAnyObjectClasses(" ");
+        assertThrows(ConfigurationException.class, () -> config.validate());
+    }
+
     @Test
     public void groupMemberAttributeNotNull() {
         config.setGroupMemberAttribute(null);
@@ -311,6 +347,8 @@ public void defaultValues() {
         assertNull(config.getGroupSearchFilter());
         assertEquals(0, config.getReadTimeout());
         assertEquals(0, config.getConnectTimeout());
+        assertEquals(CollectionUtil.newList("top"), Arrays.asList(config.getAnyObjectClasses()));
+        assertEquals(CollectionUtil.newList("entryUUID"), Arrays.asList(config.getAnyObjectNameAttributes()));
     }
 
     private static void assertCanValidate(LdapConfiguration config) {

diff --git a/src/test/java/net/tirasa/connid/bundles/ldap/LdapConnectorTestBase.java b/src/test/java/net/tirasa/connid/bundles/ldap/LdapConnectorTestBase.java
@@ -149,6 +149,12 @@ public abstract class LdapConnectorTestBase {
 
     public static final String USER_0_GIVEN_NAME = "Aaccf";
 
+    public static final String DEVICE_0_DN = "cn=Laptop,o=Small Company,dc=example,dc=com";
+
+    public static final String DEVICE_0_CN = "Laptop";
+
+    public static final String DEVICE_0_SERIALNUMBER = "42";
+
     @BeforeAll
     public static void init() throws IOException {
         InputStream propStream = null;

diff --git a/src/test/java/net/tirasa/connid/bundles/ldap/modify/LdapCreateTests.java b/src/test/java/net/tirasa/connid/bundles/ldap/modify/LdapCreateTests.java
@@ -197,6 +197,44 @@ private void doCreateArbitrary(ConnectorFacade facade) {
         assertEquals(name, newObject.getName());
     }
 
+    @Test
+    public void createArbitraryWhenNameAttributesNotDefault() {
+        LdapConfiguration config = newConfiguration();
+        assertFalse(config.getUidAttribute().equalsIgnoreCase("entryDN"));
+        config.setAnyObjectNameAttributes("cn");
+        config.setBaseContexts(SMALL_COMPANY_DN);
+        ConnectorFacade facade = newFacade(config);
+
+        doCreateDevice(facade);
+    }
+
+    @Test
+    public void createArbitraryWhenObjectClassesNotDefault() {
+        LdapConfiguration config = newConfiguration();
+        assertFalse(config.getUidAttribute().equalsIgnoreCase("entryDN"));
+        config.setAnyObjectClasses("top", "organization");
+        config.setBaseContexts(SMALL_COMPANY_DN);
+        ConnectorFacade facade = newFacade(config);
+
+        doCreateDevice(facade);
+    }
+
+    private void doCreateDevice(ConnectorFacade facade) {
+        Set<Attribute> attributes = new HashSet<>();
+        Name name = new Name(DEVICE_0_DN);
+        attributes.add(name);
+        attributes.add(AttributeBuilder.build("cn", DEVICE_0_CN));
+        attributes.add(AttributeBuilder.build("serialNumber", DEVICE_0_SERIALNUMBER));
+
+        ObjectClass oclass = new ObjectClass("device");
+        Uid uid = facade.create(oclass, attributes, null);
+
+        ConnectorObject newObject = facade.getObject(oclass, uid, null);
+        assertEquals(name, newObject.getName());
+
+    }
+
+
     @Test
     public void createBinaryAttributes() throws IOException {
         ConnectorFacade facade = newFacade();