use default renderer to prevent GPUParticles crash on macos #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project.godot
Outdated
| @@ -54,7 +54,6 @@ enabled=PackedStringArray("res://addons/format_on_save/plugin.cfg", "res://addon | |||
| [rendering] | |||
|
|
|||
| textures/canvas_textures/default_texture_filter=0 | |||
| renderer/rendering_method="gl_compatibility" | |||
There was a problem hiding this comment.
I'm still not sure which renderer is better in a sense to be as inclusive as possible to all devices and platforms (compatibility or forward), so I would keep the compatibility since the project is deployed only on the web right now (this is not a problem there?), and for mac, add a profile
renderer/rendering_method.macos="forward_plus"
like suggested here: godotengine/godot#72469 (comment)
until the bugfix is merged into the stable version of Godot.
what do you think?
There was a problem hiding this comment.
sounds good to me, I will fix the pr
debris
force-pushed
the
macos-compatibility
branch
from
80e1207 to
4c5f2ee
Compare
debris
force-pushed
the
macos-compatibility
branch
from
4c5f2ee to
72a839d
Compare
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, nice project! I tried to run it, but the project silently crashes after pressing 'Explore'. After quickly debugging I believe it's related with GPUParticles not working properly on macos M series ( godotengine/godot#72469 ). This pr works around the problem by setting the default renderer in project.godot