Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional options relating to EFB copies #190

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

threethan
Copy link
Contributor

Added EFB Filter Options for postprocessing

When the postprocess trigger is set to "On EFB Copy" an additional section of options will be visible.
image
These options allow more specificity on which EFB copies postprocessing is actually applied to.

  • Must be perspective camera: On by default, allows you to disable the perspective camera check
  • Must match screen aspect ratio: Off by default, only allows EFB copies that exactly match the aspect ratio of the render resolution.
  • Minimum Resolution %: Only allows EFB copies with a width and height that are higher than this percentage of the render resolution
  • Copy Index Filter: Can be set to only allow the second, third, or fourth EFB copy each frame. Useful for games that copy the screen multiple times, otherwise post processing would be applied multiple times per frame
  • Use "On Swap" as failsafe: On by default, Allows you to disable the built in failsafe that will apply postprocessing at the end of a frame if no valid EFB copies are found. Useful for games that sometimes render only in 2D

Added Conditional EFB Scaling (Fixes bloom in most games!)

Refer to this thread for practical uses: https://forums.dolphin-emu.org/Thread-conditional-efb-scaling-to-fix-bloom
The code I used in not the same, but has the same result.

image
The default behaviour is unchanged, by changing "Scale EFB Copies Above," EFB copies smaller than that percentage of the render res will be excluded. (For example, bloom)
"Also Scale EFB Copies Below" gives the option to allow EFB Copies below a certain threshold, useful if the first option is needed to fix bloom, but small efb copies are used by the game elsewhere.

@Tinob Tinob merged commit a5d28b5 into Tinob:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants