Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not throw exceptions if illegal characters are encoded
Encoders for strings could throw exceptions if they were used to encode characters, that are not allowed in XML. This was confusing and unexpected behavior. Therefore now such characters are filtered out.
Return either from encoding methods
Encoders can still throw exceptions, for example, if element name is incorrect, like "1stElement". To handle such errors encoder methods now return Either, not pure values. To keep old behavior
-Unsafe
methods were added.Do not throw in decoders
Decoder also could throw exceptions in some cases. Only parsing exceptions were handled. Now decoder can never throw exceptions.