Issue 17 #61
Merged
Issue 17 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sskalex
commented
May 11, 2023
| failedJob.JobId = JobBuilderHelpers.GenerateNewJobId(); | ||
| failedJob.Status = JobStatus.Failed; | ||
| failedJob.Error = error.Message + ' ' + error.StackTrace; | ||
| failedJob.StartAt = DateTime.MinValue; |
There was a problem hiding this comment.
Чтобы никого не смутил неверный StartAt позднее StartedExecuting
There was a problem hiding this comment.
Можно в случае ошибки сперва достать текущий джоб и сделать его копию, тогда StartAt из него не потеряется
wite27
approved these changes
May 12, 2023
This was referenced May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviving issue-17 PR
Issue #17