feature: Allow user to provide their own content hash to minimise IO operation #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa93hws
commented
May 18, 2022
Comment on lines
+38
to
+40
| val filenamePath = filenameSubstring.replaceFirst( | ||
| ":".toRegex(), | ||
| if (filenameSubstring.startsWith(":")) "" else "/" |
There was a problem hiding this comment.
We want //:foo/bar to be foo/bar instead of /foo/bar.
tinder-maxwellelliott
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing #107
User now can provide an optional argument
--contentHashFilepath. It is required to be a json format file with the following shape:File path in the file will be relative path from workpsace.
During content hashing phase, if the file is in the map, no IO work will be performed, content hash from the JSON file will be used instead. Otherwise, the existing solution will apply.
N.B. Most of the LOC comes from unit test