Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signature setter to Sign1Message #111

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Add signature setter to Sign1Message #111

merged 1 commit into from
Dec 15, 2023

Conversation

letmaik
Copy link
Collaborator

@letmaik letmaik commented Mar 20, 2023

Closes #105.

Note that Signer (for CoseSign) already has a setter for signature, so this brings parity between the classes.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TimothyClaeys TimothyClaeys force-pushed the letmaik/sign1-signature-setter branch from 8c2df9b to b37d386 Compare December 15, 2023 10:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@TimothyClaeys TimothyClaeys merged commit 8883ffd into TimothyClaeys:master Dec 15, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyClaeys TimothyClaeys TimothyClaeys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could the signature property of Sign1Message be made settable?
2 participants
@letmaik @TimothyClaeys