-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Prettified Corax+ Code #24
Conversation
The Corax+ test is the worst offender of the bunch, I think. Primarily because I've initially tried to keep it just the "stock" Corax89 ROM with a few patches / bug fixes. I've added more and more changes over the years, without ever really taking the time to refactor. I think your PR is an improvement overall, couple of remarks:
All in all: congratulations on a much cleaner and much easier to review pull request than the last one! Great to see you learning in real time 😄 |
To be honest, combing through the code wasn't all too bad, but some areas were sure a doosie.
Oh, and thanks! Again, I'm glad to be contributing to the test suite! |
i := image-no | ||
: test1x | ||
|
||
: test-1X-pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, yeah, I knew I wasn't going crazy. This was the only label I changed. 😄
Alright, I've done a little bit more to cleanup stuff.
|
src/tests/3-corax+.8o
Outdated
# Note by Madster: I have seen one interpreter, of which I've forgotten the | ||
# name of, that allows the execution of the opcode succeeding the return. There | ||
# is a chance that this would fail on that interpreter; however, I'll need to dig up that | ||
# interpreter to test that, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then that interpreter would be broken, and this test would successfully catch that issue ;)
Thanks! I've removed many of the newlines again :P Sorry for that, but I do think it's a lot more readable now. Thanks for your help :) |
Here's the code cleanup I mentioned doing in #22.
I might try and do the same for some of the other source files, just so it's easier for someone looking to contribute to be able to read through the code.