Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to track timely changes #554

Merged
merged 1 commit into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/trace/implementations/merge_batcher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
use std::collections::VecDeque;
use std::marker::PhantomData;

use timely::logging::WorkerIdentifier;
use timely::logging_core::Logger;
use timely::progress::frontier::AntichainRef;
use timely::progress::{frontier::Antichain, Timestamp};
Expand Down Expand Up @@ -32,7 +31,7 @@ where
/// Thing to accept data, merge chains, and talk to the builder.
merger: M,
/// Logger for size accounting.
logger: Option<Logger<DifferentialEvent, WorkerIdentifier>>,
logger: Option<Logger<DifferentialEvent>>,
/// Timely operator ID.
operator_id: usize,
/// Current lower frontier, we sealed up to here.
Expand All @@ -52,7 +51,7 @@ where
type Time = M::Time;
type Output = M::Chunk;

fn new(logger: Option<Logger<DifferentialEvent, WorkerIdentifier>>, operator_id: usize) -> Self {
fn new(logger: Option<Logger<DifferentialEvent>>, operator_id: usize) -> Self {
Self {
logger,
operator_id,
Expand Down
3 changes: 1 addition & 2 deletions src/trace/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ pub mod description;
pub mod implementations;
pub mod wrappers;

use timely::logging::WorkerIdentifier;
use timely::logging_core::Logger;
use timely::progress::{Antichain, frontier::AntichainRef};
use timely::progress::Timestamp;
Expand Down Expand Up @@ -310,7 +309,7 @@ pub trait Batcher {
/// Times at which batches are formed.
type Time: Timestamp;
/// Allocates a new empty batcher.
fn new(logger: Option<Logger<DifferentialEvent, WorkerIdentifier>>, operator_id: usize) -> Self;
fn new(logger: Option<Logger<DifferentialEvent>>, operator_id: usize) -> Self;
/// Adds an unordered container of elements to the batcher.
fn push_container(&mut self, batch: &mut Self::Input);
/// Returns all updates not greater or equal to an element of `upper`.
Expand Down
Loading