Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements around consolidation.
First, the
consolidate_container
method was made into a trait method onConsolidateLayout
, which it required anyhow. This provides a default implementation, but allows other implementors to provide their own optimized implementation. For example,Vec<(D, T, R)>
can simply consolidate in place and thenmem::swap
, which it does. This should make the chunkers based onConsolidateLayout
appropriate forVec
. I also renamed itconsolidate_into
, which made more sense once it took a&mut self
argument.Second, the implementation of
consolidate_into
was streamlined. It maintained anOption
of the previous key and diff, but always sets this in the first iteration. We can simply take the first step and then maintain a non-optional previous key and diff. Minor, but should be simplifying.