Introduce IsZero
trait for is_zero()
#503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts
is_zero()
fromSemigroup
, which now requires it instead. The reasoning is that whileSemigroup<Rhs>
can have multipleRhs
implementations, there cannot be multipleis_zero()
implementations, and we want to avoid confusion there. In fact, it isn't especially clear what being a zero means for any otherRhs
, and we don't really end up usingis_zero()
in support of semigroup actions as much as once accumulation has been accomplished, determining whether to discard the update or not.