Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR attempts to minimize opinions on owned items, then references to owned items, and then a few more bounds. Roughly, almost no one cared about the specifics of
BatchContainer::OwnedItem
, which is great news because it is a source of annoyance. Once no one cares about this, also no one cares thatBatchContainer::ReadItem
implementIntoOwned
, which is also great.One casualty is
option_container.rs
, which ... is software architected around using theC::OwnedItem
to drive its opinions on things, whereas otherwise idiomatic code has an owned type in mind but also the good graces to name it specifically rather than ask the batch container to be the one to remember. We could probably rewrite it to work, but it was only demo code in the first place, and the Huffman container should keep us honest about GATs.