Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring differential to Rust 2021 #443

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

antiguru
Copy link
Member

@antiguru antiguru commented Dec 7, 2023

What started as a simple change to visibility .. went sideways. This PR does the following:

  • It adds edition = "2021" to all crates in the workspace.
  • It adds all crates as workspace members to the root Cargo.toml. Advent-of-code 2017 and tpchlike are commented because they don't compile anymore, and I didn't want to spend time on fixing.
  • It changes includes and extern crate definitions to the new language level.
  • It changes the dependency on Timely to a workspace dependency, which makes it easier to point to a different Timely version globally.

The motivation is twofold: It's good to update to a more recent language level, and it increases build/test coverage for code in the repository.

It also makes the merge batcher variants pub, so one can define a new spine type outside Differential.

What started as a simple change to visibility .. went sideways.

Signed-off-by: Moritz Hoffmann <[email protected]>
@frankmcsherry frankmcsherry merged commit d9d4db6 into TimelyDataflow:master Dec 7, 2023
1 check passed
@antiguru antiguru deleted the visibility branch December 7, 2023 20:50
@frankmcsherry
Copy link
Member

Thank you!

This was referenced Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants