Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request price at block instead of the latest price #55

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

pouya-eghbali
Copy link
Member

No description provided.

@pouya-eghbali pouya-eghbali marked this pull request as ready for review February 2, 2024 20:20
@pouya-eghbali pouya-eghbali added the WTD Trigger What-The-Diff label Feb 2, 2024
Copy link

what-the-diff bot commented Feb 2, 2024

PR Summary

  • Version Upgrade
    The software version was upgraded from "0.11.0" to "0.11.1" as denoted in the 'root.go' file. This usually signifies minor fixes, improvements or new small features.

  • Addition of Import Statement
    A new import statement for go-ethereum/accounts/abi/bind has been added to 'uniswap.go'. This signifies a newly added capability to bind Ethereum contract ABI (Application Binary Interface), which may provide additional Ethereum-related functionality.

  • Modification of Function Call
    In the GetPriceFromPair function located in the 'uniswap.go' file, there was a modification to a function call Slot0. A new parameter bind.CallOpts has been added, which includes a field BlockNumber. This may help to specify specific details or options when making the call, potentially yielding more accurate or efficient results.

@pouya-eghbali pouya-eghbali merged commit e70bf84 into master Feb 2, 2024
1 check passed
@pouya-eghbali pouya-eghbali deleted the fix-eth-block-req branch February 2, 2024 20:31
logicalangel pushed a commit that referenced this pull request Apr 3, 2024
Request price at block instead of the latest price
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WTD Trigger What-The-Diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant