Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate constraint package #945

Merged
merged 1 commit into from
Jul 11, 2024
Merged

chore: deprecate constraint package #945

merged 1 commit into from
Jul 11, 2024

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Jul 10, 2024 •
edited
Loading

Constraint packages are still used internally, as there is no way to remove them without breaking backwards compatibility.
All user-facing references to them have been deprecated though.

@triceo triceo requested a review from zepfred July 10, 2024 13:41
@triceo triceo marked this pull request as ready for review July 10, 2024 13:42
@triceo triceo self-assigned this Jul 10, 2024
@triceo triceo added this to the v1.13.0 milestone Jul 10, 2024
@triceo triceo linked an issue Jul 10, 2024 that may be closed by this pull request
Feat: Deprecate constraint package #941
Closed
@triceo triceo removed this from the v1.13.0 milestone Jul 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
71.2% Coverage on New Code (required ≥ 75%)

See analysis details on SonarCloud

zepfred
zepfred approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@zepfred zepfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@triceo triceo merged commit 44187cb into TimefoldAI:main Jul 11, 2024
23 of 24 checks passed
@triceo triceo deleted the unknown branch July 11, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepfred zepfred zepfred approved these changes

Assignees

@triceo triceo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Deprecate constraint package
2 participants
@triceo @zepfred