Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to consume the initialized solution #915

Merged
merged 13 commits into from
Jun 27, 2024

Conversation

zepfred
Copy link
Contributor

@zepfred zepfred commented Jun 24, 2024

By definition, the initialized solution is always generated by the phase immediately prior to the first Local Search phase.

This pull request adds a new consumer, allowing the solver to inject the initialized solution when a valid initialization phase is identified.

@zepfred zepfred force-pushed the initialize-solution branch from 7db97ff to 30d23a2 Compare June 24, 2024 12:42
@zepfred
Copy link
Contributor Author

zepfred commented Jun 24, 2024

The job Downstream - Timefold Solver Enterprise for Python is failing because it is not fetching the correct branch version. The fix is included in this pull request, but it needs to be merged to take effect.

@zepfred zepfred marked this pull request as ready for review June 24, 2024 21:00
@zepfred zepfred requested a review from triceo June 24, 2024 21:00
Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! Please see comments inline.

@zepfred zepfred force-pushed the initialize-solution branch from 1eb30fd to 868766f Compare June 25, 2024 18:25
@triceo triceo requested a review from rsynek June 25, 2024 18:28
@triceo
Copy link
Contributor

triceo commented Jun 25, 2024

@rsynek Can you please review the async-related stuff?

@zepfred zepfred requested a review from triceo June 25, 2024 18:36
@zepfred zepfred force-pushed the initialize-solution branch from dbcd7e0 to e18cd20 Compare June 25, 2024 18:41
@zepfred zepfred force-pushed the initialize-solution branch 2 times, most recently from baa46b7 to 87f85c4 Compare June 25, 2024 19:40
@zepfred zepfred force-pushed the initialize-solution branch from 87f85c4 to 8959c96 Compare June 25, 2024 20:54
Copy link
Contributor

@rsynek rsynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @zepfred !

I described one hypothetical problematic situation, but the question is whether it can even happen.

Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comments resolved.

Copy link

@triceo triceo merged commit 84e4ae0 into TimefoldAI:main Jun 27, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants