Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address various issues identified during benchmarking #90

Merged
merged 1 commit into from
Jun 14, 2023
Merged

fix: address various issues identified during benchmarking #90

merged 1 commit into from
Jun 14, 2023

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Jun 14, 2023 •
edited
Loading

Includes the following fixes:

  • NPE in the benchmark report when no subsingles used.
  • Exception in 2-opt in some VRP cases.
  • More appropriate (but much slower) mutation counting in entities.
  • Mutation chart correctly drops to zero on the next tick.
  • Charts correctly respond to when datasets are removed.
  • Screenshots in the documentation match what the benchmarker will actually generate.

@triceo triceo added this to the 1.0.0 milestone Jun 14, 2023
@triceo triceo requested a review from rsynek June 14, 2023 14:19
@triceo triceo changed the title bug: address various issues identified during benchmarking fix: address various issues identified during benchmarking Jun 14, 2023
rsynek
rsynek approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@rsynek rsynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; one small suggestion.

...mpl/src/main/java/ai/timefold/solver/core/impl/domain/solution/mutation/MutationCounter.java Outdated Show resolved Hide resolved
@triceo triceo merged commit 45d3931 into TimefoldAI:main Jun 14, 2023
@triceo triceo deleted the benchmarker2 branch June 14, 2023 19:08
@timefold-release
Copy link
Contributor

🎉 This issue has been resolved in v0.10.0 (Release Notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsynek rsynek rsynek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@triceo @timefold-release @rsynek