Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removing examples module #809

Merged
merged 3 commits into from
Apr 26, 2024
Merged

chore: Removing examples module #809

merged 3 commits into from
Apr 26, 2024

Conversation

zepfred
Copy link
Contributor

@zepfred zepfred commented Apr 22, 2024 •
edited
Loading

This PR removes the examples module.

@triceo
Copy link
Contributor

triceo commented Apr 22, 2024 •
edited
Loading

Depends on:
#800

Let's also add a note to the upgrade recipe, similar to this one:
https://docs.timefold.ai/timefold-solver/latest/upgrade-and-migration/upgrade-to-latest-version#_upgrade_from_1_8_0_to_1_9_0

Something along the lines that we've removed all of the legacy examples and turned them into quickstarts.

@triceo triceo self-requested a review April 22, 2024 13:39
triceo
triceo approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The predecessor PR has been merged.
This may be merged once rebased on latest main.

@triceo
Copy link
Contributor

triceo commented Apr 25, 2024

I don't understand why, or why this PR would cause it, but the test is failing consistently. I re-ran it and it also failed.

@zepfred
Copy link
Contributor Author

zepfred commented Apr 25, 2024

I don't understand why, or why this PR would cause it, but the test is failing consistently. I re-ran it and it also failed.

It's strange because it's passing locally.

@zepfred zepfred marked this pull request as ready for review April 25, 2024 23:25
@zepfred
Copy link
Contributor Author

zepfred commented Apr 25, 2024

@triceo It is now passing, but I am unsure what happened before. I just applied the necessary upgrades and promoted the PR to 'ready for review'.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@triceo triceo merged commit a210d93 into TimefoldAI:main Apr 26, 2024
18 checks passed
@zepfred zepfred deleted the remove-tennis branch April 26, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triceo triceo triceo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zepfred @triceo