Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove ServiceLoader use from the codebase #705

Merged
merged 11 commits into from
Mar 12, 2024
Merged

chore: Remove ServiceLoader use from the codebase #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3b9a991
Move CS to the correct impl package
triceo Mar 11, 2024
94cae57
Move collectors to their own package
triceo Mar 11, 2024
4a3b4e8
Fold constraint-streams into core-impl
triceo Mar 11, 2024
f36d6e2
Fold core-impl into core and move it to top level
triceo Mar 11, 2024
00d567f
Remove JoinerService
triceo Mar 11, 2024
e916f82
Remove ScoreDirectorFactoryService
triceo Mar 11, 2024
82cc784
Remove ServiceLoader for Enterprise as well
triceo Mar 11, 2024
f071f94
Fix parent
triceo Mar 11, 2024
6325b6f
Fix parent for real
triceo Mar 11, 2024
623f067
docs: upgrade recipe
triceo Mar 12, 2024
c6a9ed0
ci: fix Revapi
triceo Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 1 addition & 3 deletions benchmark/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
</dependency>
<dependency>
<groupId>ai.timefold.solver</groupId>
<artifactId>timefold-solver-core-impl</artifactId>
<artifactId>timefold-solver-core</artifactId>
<type>test-jar</type>
<scope>test</scope>
</dependency>
Expand Down Expand Up @@ -238,11 +238,9 @@
<artifactId>maven-dependency-plugin</artifactId>
<configuration>
<ignoredUsedUndeclaredDependencies>
<dependency>ai.timefold.solver:timefold-solver-core-impl:jar</dependency>
<dependency>org.webjars:*:jar</dependency>
</ignoredUsedUndeclaredDependencies>
<ignoredUnusedDeclaredDependencies>
<dependency>ai.timefold.solver:timefold-solver-core:jar</dependency>
<dependency>org.webjars:*:jar</dependency>
</ignoredUnusedDeclaredDependencies>
</configuration>
Expand Down
26 changes: 2 additions & 24 deletions build/bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,35 +38,13 @@
</dependency>
<dependency>
<groupId>ai.timefold.solver</groupId>
<artifactId>timefold-solver-core-impl</artifactId>
<version>${version.ai.timefold.solver}</version>
</dependency>
<dependency>
<groupId>ai.timefold.solver</groupId>
<artifactId>timefold-solver-core-impl</artifactId>
<version>${version.ai.timefold.solver}</version>
<classifier>sources</classifier>
</dependency>
<dependency>
<groupId>ai.timefold.solver</groupId>
<artifactId>timefold-solver-core-impl</artifactId>
<type>test-jar</type>
<version>${version.ai.timefold.solver}</version>
</dependency>
<dependency>
<groupId>ai.timefold.solver</groupId>
<artifactId>timefold-solver-constraint-streams</artifactId>
<version>${version.ai.timefold.solver}</version>
</dependency>
<dependency>
<groupId>ai.timefold.solver</groupId>
<artifactId>timefold-solver-constraint-streams</artifactId>
<artifactId>timefold-solver-core</artifactId>
<version>${version.ai.timefold.solver}</version>
<classifier>sources</classifier>
</dependency>
<dependency>
<groupId>ai.timefold.solver</groupId>
<artifactId>timefold-solver-constraint-streams</artifactId>
<artifactId>timefold-solver-core</artifactId>
<type>test-jar</type>
<version>${version.ai.timefold.solver}</version>
</dependency>
Expand Down
87 changes: 0 additions & 87 deletions core/constraint-streams/pom.xml
View file
Open in desktop

This file was deleted.

52 changes: 0 additions & 52 deletions ...i/timefold/solver/constraint/streams/bavet/BavetConstraintStreamScoreDirectorFactory.java
View file
Open in desktop

This file was deleted.

84 changes: 0 additions & 84 deletions ...old/solver/constraint/streams/bavet/BavetConstraintStreamScoreDirectorFactoryService.java
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions ...streams/src/main/java/ai/timefold/solver/constraint/streams/bavet/common/TupleSource.java
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions .../src/main/java/ai/timefold/solver/constraint/streams/bavet/common/index/package-info.java
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions ...solver/constraint/streams/common/AbstractConstraintStreamScoreDirectorFactoryService.java
View file
Open in desktop

This file was deleted.

72 changes: 0 additions & 72 deletions ...eams/src/main/java/ai/timefold/solver/constraint/streams/common/DefaultJoinerService.java
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...META-INF/services/ai.timefold.solver.core.impl.score.director.ScoreDirectorFactoryService
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion .../main/resources/META-INF/services/ai.timefold.solver.core.impl.score.stream.JoinerService
View file
Open in desktop

This file was deleted.

Loading
Loading