Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Nearby configuration by exception #673

Merged
merged 15 commits into from
Mar 5, 2024

Conversation

zepfred
Copy link
Contributor

@zepfred zepfred commented Feb 28, 2024

This pull request adds easy configuration of the Nearby Selection feature and updates the local search phase factory to provide default selectors when custom configuration is not provided. The configuration for the selectors is listed below:

  1. Basic variables selectors: Change, Swap, Change with nearby selection, and Swap with nearby selection.
  2. List variables selectors: Change, Swap, Change with nearby selection, Swap with nearby selection, 2-OPT with nearby selection.
  3. Chained variables selectors: Change, Swap, Change with nearby selection, Swap with nearby selection, Tail Chain Swap with nearby selection.

The following XML configuration can be used to enable Nearby selection quickly:

<nearbyDistanceMeterClass>...</nearbyDistanceMeterClass>

If there are multiple entities, we will fail fast.

@zepfred zepfred force-pushed the default-nearby-configuration branch 3 times, most recently from cb1d5e0 to 23cecbe Compare February 28, 2024 17:00
@zepfred zepfred requested a review from triceo February 28, 2024 17:19
Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving some questions that we should consider.

@zepfred zepfred force-pushed the default-nearby-configuration branch from e462a2b to 4cac163 Compare March 5, 2024 00:40
@zepfred zepfred requested a review from triceo March 5, 2024 00:50
Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after final comments are resolved.

@zepfred zepfred force-pushed the default-nearby-configuration branch from 231d66b to 5e3375f Compare March 5, 2024 10:57
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
26.9% Coverage on New Code (required ≥ 75%)

See analysis details on SonarCloud

@triceo triceo merged commit 55c373b into TimefoldAI:main Mar 5, 2024
10 of 12 checks passed
@zepfred zepfred deleted the default-nearby-configuration branch March 27, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants