-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding Nearby configuration by exception #673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepfred
force-pushed
the
default-nearby-configuration
branch
3 times, most recently
from
February 28, 2024 17:00
cb1d5e0
to
23cecbe
Compare
triceo
reviewed
Mar 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving some questions that we should consider.
...l/src/main/java/ai/timefold/solver/core/impl/localsearch/DefaultLocalSearchPhaseFactory.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/ai/timefold/solver/core/impl/localsearch/DefaultLocalSearchPhaseFactory.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/ai/timefold/solver/core/impl/localsearch/DefaultLocalSearchPhaseFactory.java
Show resolved
Hide resolved
...l/src/main/java/ai/timefold/solver/core/impl/localsearch/DefaultLocalSearchPhaseFactory.java
Outdated
Show resolved
Hide resolved
zepfred
force-pushed
the
default-nearby-configuration
branch
from
March 5, 2024 00:40
e462a2b
to
4cac163
Compare
triceo
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after final comments are resolved.
...l/src/main/java/ai/timefold/solver/core/impl/localsearch/DefaultLocalSearchPhaseFactory.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/ai/timefold/solver/core/impl/localsearch/DefaultLocalSearchPhaseFactory.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/ai/timefold/solver/core/impl/localsearch/DefaultLocalSearchPhaseFactory.java
Outdated
Show resolved
Hide resolved
zepfred
force-pushed
the
default-nearby-configuration
branch
from
March 5, 2024 10:57
231d66b
to
5e3375f
Compare
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds easy configuration of the Nearby Selection feature and updates the local search phase factory to provide default selectors when custom configuration is not provided. The configuration for the selectors is listed below:
The following XML configuration can be used to enable Nearby selection quickly:
<nearbyDistanceMeterClass>...</nearbyDistanceMeterClass>
If there are multiple entities, we will fail fast.