chore: Enabling SonarCloud for forks #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@triceo, the current SonarCloud configuration will trigger the workflow for opened and reopened PR or every time the PR is updated. Is this the expected behavior? |
|
Yes, it is. Should't I be seeing Sonar here now? |
I don't think so. It should be merged first. |
triceo
approved these changes
Feb 15, 2024
zepfred
added a commit
to zepfred/timefold-solver
that referenced
this pull request
Feb 15, 2024
This reverts commit b9a59ba.
triceo
pushed a commit
that referenced
this pull request
Feb 15, 2024
zepfred
added a commit
to zepfred/timefold-solver
that referenced
this pull request
Feb 15, 2024
This reverts commit 04c7c9f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the SonarCloud workflow to function with forked repositories as well. The
pull_request_targetevent works similarly topull_request, but runs on the base branch and allows using secrets. Therefore, the PR ref version needs to be specified in the workflow script.