Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nearby selection pinning support #614

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Feb 5, 2024

No description provided.

@triceo triceo added bug Something isn't working regression A bug that was caused by another commit; usually indicates lack of test coverage. labels Feb 5, 2024
WIP
WIP
Copy link
Contributor

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new pinning check. Maybe the Javadoc for

public interface IterableSelector<Solution_, T> extends Selector<Solution_>, Iterable<T> {
or
public interface MoveSelector<Solution_> extends IterableSelector<Solution_, Move<Solution_>> {
should explicitly mention the selector can return null.

Copy link
Contributor

@winklerm winklerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the FSR model perspective, thank you!

@triceo triceo merged commit 5c3bcdf into TimefoldAI:main Feb 6, 2024
9 of 10 checks passed
@triceo triceo deleted the pinning branch February 6, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression A bug that was caused by another commit; usually indicates lack of test coverage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants