Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ruin and Recreate move reversion #1309

Closed
wants to merge 7 commits into from
Closed

fix: Ruin and Recreate move reversion #1309

wants to merge 7 commits into from

Conversation

zepfred
Copy link
Contributor

@zepfred zepfred commented Jan 8, 2025

No description provided.

@zepfred zepfred linked an issue Jan 8, 2025 that may be closed by this pull request
fix: Ruin and Recreate index out of bound #1305
Closed
@zepfred zepfred had a problem deploying to documentation (preview) January 8, 2025 14:32 — with GitHub Actions Failure
@zepfred zepfred marked this pull request as draft January 8, 2025 14:32
@zepfred zepfred force-pushed the fix-ruin-recreate branch from 032b070 to 0795c13 Compare January 8, 2025 14:36
@zepfred zepfred had a problem deploying to documentation (preview) January 8, 2025 14:36 — with GitHub Actions Failure
@zepfred zepfred had a problem deploying to documentation (preview) January 8, 2025 22:17 — with GitHub Actions Failure
@zepfred zepfred had a problem deploying to documentation (preview) January 9, 2025 14:50 — with GitHub Actions Failure
@zepfred zepfred had a problem deploying to documentation (preview) January 9, 2025 17:56 — with GitHub Actions Failure
@zepfred zepfred marked this pull request as ready for review January 9, 2025 17:56
@zepfred zepfred requested a review from triceo January 9, 2025 17:56
@zepfred zepfred had a problem deploying to documentation (preview) January 9, 2025 18:09 — with GitHub Actions Failure
@zepfred zepfred had a problem deploying to documentation (preview) January 9, 2025 19:09 — with GitHub Actions Failure
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
95.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

triceo
triceo reviewed Jan 12, 2025
View reviewed changes
Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the recorder situation can be simplified. The move should not really deal with what's recorded, and what's a custom change. The move should just say what it wants - it wants some changes to not be delegated.

...imefold/solver/core/impl/heuristic/selector/move/generic/list/ruin/ListRuinRecreateMove.java Show resolved Hide resolved
@zepfred
Copy link
Contributor Author

zepfred commented Jan 15, 2025

Fixed by #1320

@zepfred zepfred closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triceo triceo triceo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: Ruin and Recreate index out of bound
2 participants
@zepfred @triceo