-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add PlanningPinToIndex to Python #1191
fix: Add PlanningPinToIndex to Python #1191
Conversation
Fixes #1190 |
… of int JPyInterpreter - Allow annotations to specify a type to override the generated getter return type. When a type is specified, it goes through the generic PythonLikeObject to Java Object convertor. Python - Add PlanningPinToIndex - Make PlanningPin use the new JPyInterpreter mechanism to remove code that converts a PlanningPin to Pinning filter Java - Make PlanningPinToIndex support Integer, since its Javadoc says null is a valid value
19bef2d
to
2968ede
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field should not support null
values - there is no reason for why the field should have a reference type. If the Javadoc says it, let's fix the Javadoc.
Counterpoint:
|
You could also say that we shouldn't repeat mistakes of the past.
I agree. Performance is irrelevant here. I simply do not see the point of allowing this field to have a third state (
This particular type has not supported We can add it if we ever see the need. But I am not a fan of adding options that nobody is calling for. |
|
JPyInterpreter
Python
Build
tox.ini