Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support assigned values for Recommendations as well #1136

Merged
merged 11 commits into from
Oct 7, 2024
Merged

feat: support assigned values for Recommendations as well #1136

merged 11 commits into from
Oct 7, 2024

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Oct 7, 2024

No description provided.

@triceo triceo requested a review from zepfred October 7, 2024 09:30
@triceo triceo linked an issue Oct 7, 2024 that may be closed by this pull request
Feat: Allow Recommendations to explain why a particular assignment is made #1122
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
1 Accepted issue

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

zepfred
zepfred previously approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@zepfred zepfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern about AssignmentProcessor has already been addressed. Therefore, the changes look great to me.
+1 after checking the comments related to the tests of deprecated methods.

@triceo triceo merged commit 11cd2fb into TimefoldAI:main Oct 7, 2024
23 of 26 checks passed
@triceo triceo deleted the recommend branch October 7, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepfred zepfred zepfred left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Allow Recommendations to explain why a particular assignment is made
2 participants
@triceo @zepfred