Allow custom number and lettering fonts for keypad button #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aw, while custom fonts and lettering is a good idea (Especially when updating the visual style for iOS 11), having a single property isn't sufficient. There are 3 separate layout objects that control the sizing of the font depending on the width of the screen (ie, iPhone SE, iPhone 8 Plus, and iPad), so in order to properly add custom fonts, a mechanism to set the font for each layout object would be needed. |
|
Um, so because of issue #31, I need to redesign the whole view controller now. As part of that, this code is probably going to all go away. :( Thanks for the PR though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.