Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update evp1d implementation #21

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

apcraig
Copy link

@apcraig apcraig commented Nov 14, 2023

- Rename halo_HTE_HTN to global_ext_halo and move into ice_grid.F90
- Generalize global_ext_halo to work with any nghost size (was hardcoded for nghost=1)
- Remove argument from dyn_evp1d_init, change to "use" of global grid variables
- rename pgl_global_ext to save_ghte_ghtn
- Update allocation of G_HTE, G_HTN
- Add dealloc_grid to deallocate G_HTE and G_HTN at end of initialization
- Add calls to dealloc_grid to all CICE_InitMod.F90 subroutines
- Make dimension of evp1d arguments implicit size more consistently
- Clean up indentation and formatting a bit

Full test suites run on cheyenne, all tests pass. Also ran decomp_suite with evp1d which also passes. Tested vs main #8916b9ff2c due to age of branch. Will retest PR with current main prior to merging PR to CICE-Consortium.

- Rename halo_HTE_HTN to global_ext_halo and move into ice_grid.F90
- Generalize global_ext_halo to work with any nghost size (was hardcoded for nghost=1)
- Remove argument from dyn_evp1d_init, change to "use" of global grid variables
- rename pgl_global_ext to save_ghte_ghtn
- Update allocation of G_HTE, G_HTN
- Add dealloc_grid to deallocate G_HTE and G_HTN at end of initialization
- Add calls to dealloc_grid to all CICE_InitMod.F90 subroutines
- Make dimension of evp1d arguments implicit size more consistently
- Clean up indentation and formatting a bit
@apcraig
Copy link
Author

apcraig commented Nov 14, 2023

There is quite a bit of whitespace change, you can ignore those diffs by going to the "Files changed", click on settings (the gear), and click "hide whitespace"

@TillRasmussen TillRasmussen merged commit 7f3703c into TillRasmussen:evp1d_implement Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants