-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-release test for TileDB-SOMA 1.2.3 #18
Conversation
I don't know why this is failing:
given that at |
I don't think it's related to the test changes in this PR. I just synced "main" on my fork of the feedstock, and it failed with the same error https://github.com/jdblischak/tiledbsoma-feedstock/tree/bb3fbeb622d88809cf20bc8b58c3a480803334c7 |
I'm having trouble reproducing the solver error locally on Ubuntu. In the CI builds, libtiledbsoma builds fine, but then fails to solve the env once it tries to build the Python client:
|
Close/reopen to re-trigger CI |
Pre-release green CI verified; closing as intended. |
The nightly binaries from #19 have already been uploaded, so you could even locally install the latest version built from "main" https://anaconda.org/tiledb/libtiledbsoma/files?channel=nightlies You can install them locally by running the following: mamba create -n soma-nightly --override-channels \
-c conda-forge -c "tiledb/label/nightlies" -c tiledb \
tiledbsoma-py="*20230503"
conda activate soma-nightly
conda list soma
## libtiledbsoma 1.2.2.dev20230503 hc1eed26_0 tiledb/label/nightlies
## somacore 1.0.0 pyh4471522_1 tiledb
## tiledbsoma-py 1.2.2.dev20230503 py310h7717f27_0 tiledb/label/nightlies
python -c "import tiledbsoma; print(tiledbsoma.pytiledbsoma.version())"
## libtiledb=2.15.2 |
Actually there was contentful stuff on here -- this PR was conflating two things:
@Shelnutt2 @jdblischak would it be better to re-open #17 and get it merged, then do the 1.2.3 release per se? Or, would it be better to fold the #17 content into the (upcoming) actually-release-1.2.3 PR? |
If the updated version restriction applies to 1.2.2, then I think it makes sense to merge that first (just bump the build number), and then later update to 1.2.3 (and return the build number to 0). |
Ah of course @jdblischak ; I should have looked at it that way. The restriction on TileDB core >=2.15.2 and TileDB-Py >= 0.21.3 is specifically for TileDB-SOMA 1.2.3. So, doing separate PRs would not make sense after all. |
Not to be merged. Just a check for "is the putative TileDB-SOMA 1.2.3 Conda-CI green?".