-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove temporary pr-4995.patch #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That Core PR might be responsible for failures in MariaDB, but let's merge this for the feedstock nightlies.
Also, to demonstrate that this will fix the nightly builds, I manually deleted the patch in the nightly-build branch and pushed to my fork. The builds haven't completed yet, but they no longer fail at the early stage of applying the patches. |
Update: The linux-64 build completed successfully. However, the build is going to fail since it is unable to upload the binary to anaconda.org, since I didn't update my fork to handle this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It would be nice if we could use patch -N
here, but I guess the call to patch
is buried somewhere inside of conda-build.
"buried" is definitely the correct term. I did a quick search of how they call |
…B-Inc#100 This reverts commit 2cd189f.
WARNING: Do not copy-paste this code. The
git rm
command had to be fixed in #103 to properly use-C
Closes #98
Details in #98 (comment)