Implement filter pipeline framework #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. Groundwork for #156.
tdenniston
requested review from
Shelnutt2,
jakebolewski and
stavrospapadopoulos
stavrospapadopoulos
approved these changes
Aug 26, 2018
|
|
||
| // Run each chunk through the entire pipeline. | ||
| parallel_for(0, chunks.size(), [&](uint64_t i) { | ||
| // TODO(ttd): can we instead allocate one FilterStorage per thread? |
There was a problem hiding this comment.
Noting here after a discussion with @tdenniston that probably the easiest way forward is to do static work partitioning and allocate one Filter storage class per work partition (thread). As the work across threads is equally proportional, it should perform well.
jakebolewski
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently used only for compression. Groundwork for #156.
Besides the filter and filter pipeline implementations, the changes to existing functionality by this PR are:
CompressionFilter.FilterPipelines. No changes to metadata serialization or format with this PR.