Show errant values in current-domain out-of-bounds error message

[johnkerl]

[sc-61579]

Before:

tiledbsoma._exception.SOMAError: [ManagedQuery] [unnamed] Query FAILED: Query: A range was set outside the current domain.

After:

tiledbsoma._exception.SOMAError: [ManagedQuery] [unnamed] Query FAILED: Query: A range [99999, 99999] on dimension 'soma_joinid' was set outside of the current domain [[0, 2637]].

---

TYPE: IMPROVEMENT
DESC: Show errant values in current-domain out-of-bounds error message

[ihnorton]

Shouldn't this be current_domain()?

[johnkerl]

We need the domain to get types. Those are wired through array_schema_ and current_domain both. I can get them either way.

[johnkerl]

@ihnorton correction: the domain is wired through the array_schema_ and the private ndrectangle_ of CurrentDomain.

It is an invariant that they be the same domain in both places.

If you want to pursue the latter then we need to connect a domain accessor in CurrentDomain which passes through the copy of the domain in its ndrectangle_. Personally I don't see the benefit to doing the latter.

[johnkerl]

Even though we moved to C++ 20 a long time ago, it appears that in CI there are lots of builds using C++ 17. And I've introduced std::format on this PR. Hence all the red CI.

@ihnorton @teo-tsirpanis your thoughts please:

• I can use fmt::format
• I can std::stringstream ss, ss << "this", ss << "that", etc. & then throw QueryException(ss.str())

[teo-tsirpanis]

it appears that in CI there are lots of builds using C++ 17

That's definitely not the case, we use C++20 language features like concepts without any problem. It looks like the compiler versions we are using do not have the library implemented.

Better use fmt instead.

[teo-tsirpanis]

Thanks!

[johnkerl]

Thank you @teo-tsirpanis !!